Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cubesql): Support float*interval and interval/float #8496

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

mcheshkov
Copy link
Member

@mcheshkov mcheshkov commented Jul 19, 2024

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Bump datafusion version and add tests for interval multiplication and division with floats

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.95%. Comparing base (149eb01) to head (7ad8ef9).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8496      +/-   ##
==========================================
+ Coverage   81.93%   81.95%   +0.01%     
==========================================
  Files         199      199              
  Lines       76201    76235      +34     
==========================================
+ Hits        62437    62476      +39     
+ Misses      13764    13759       -5     
Flag Coverage Δ
cubesql 81.95% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

vercel bot commented Jul 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Jul 22, 2024 2:20pm
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Jul 22, 2024 2:20pm
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Jul 22, 2024 2:20pm
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Jul 22, 2024 2:20pm
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Jul 22, 2024 2:20pm
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Jul 22, 2024 2:20pm
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Jul 22, 2024 2:20pm
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Jul 22, 2024 2:20pm

@mcheshkov mcheshkov marked this pull request as ready for review July 22, 2024 15:58
@mcheshkov mcheshkov requested review from a team as code owners July 22, 2024 15:58
@mcheshkov mcheshkov merged commit 300f8fc into master Jul 22, 2024
77 checks passed
@mcheshkov mcheshkov deleted the interval-float-mul-div branch July 22, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants